[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Re: [PATCH] trunk doesn't compile on cygwin
From: |
Matthew Gregan |
Subject: |
Re: [Monotone-devel] Re: [PATCH] trunk doesn't compile on cygwin |
Date: |
Wed, 21 Jun 2006 09:27:07 +1200 |
User-agent: |
Mutt/1.5.11+cvs20060403 |
At 2006-06-16T20:43:13+0200, Lapo Luchini wrote:
> > xdelta.cc:88: instantiated from here
> > /usr/lib/gcc/i686-pc-cygwin/3.4.4/include/c++/ext/hashtable.h:518:
> > error: no match for call to `(const hashmap::hash<u32>) (const long
> > unsigned int&)' make[2]: *** [mtn-xdelta.o] Error 1
> OK, I found a solution.
> hashmap template seems to miss an operator() that can apply to
> "unsigned long int", such as the ones used in xxdelta.cc.
Eh, I'm not entirely sure why this is a problem on Cygwin either. We
haven't seen it on other platforms, even with the same version of GCC, etc.
Anyway, your patch works, and won't harm other platforms (we already have a
specialization for unsigned int anyway), so I've committed a similar fix.
Thanks for chasing this up!
Cheers,
-mjg
--
Matthew Gregan |/
/| address@hidden