monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] [patch] adding branchname to parameters for validat


From: Marcel van der Boom
Subject: Re: [Monotone-devel] [patch] adding branchname to parameters for validate_commit_message
Date: Tue, 26 Sep 2006 12:01:19 +0200


On 26 sep 2006, at 10:47, Nathaniel Smith wrote:

On Fri, Sep 22, 2006 at 06:05:36PM +0200, Marcel van der Boom wrote:
On 18 sep 2006, at 22:21, Nathaniel Smith wrote:
On Mon, Sep 18, 2006 at 07:35:08PM +0200, Marcel van der Boom wrote:
Included is a small patch which adds branchname as a third parameter
for the validate_commit_message.

Looks fine to me, except you left out the tests ;-).

(See tests/commit_validation_lua_hook and I guess
tests/i18n_commit_messages maybe should be updated for consistency.)

Updated patch attached.

Applied to mainline.

Cool, thanks a lot. The changes i made in i18n_commit_messages were redundant i guess? (i.e. testing the branchname again there)

marcel
--
Marcel van der Boom
HS-Development BV               --   http://www.hsdev.com
So! webapplicatie framework  --   http://make-it-so.info


Attachment: smime.p7s
Description: S/MIME cryptographic signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]