Re: [Monotone-devel] [RFC] Monotone NETSYNC Hook Extension & Abstraction Layer

[Ralf S. Engelschall]

On Tue, Sep 25, 2007, Nathaniel Smith wrote:

> On Tue, Sep 25, 2007 at 08:24:11PM +0200, Ralf S. Engelschall wrote:
> > Yes, we have not just considered this but if you look at the patch it
> > is also implemented. Each Lua hook can return four value: "accept",
> > "ignore", "rollback:<message>" and "abort:<message>". Currently we
> > are using mainly "accept" and "rollback:<message>", but the approach
> > you mentioned is achieved by returning "ignore". Then the cert would
> > silently be just ignored.
>
> Yes, I agree.
>
> My question is whether the 10-20 line patch to implement just this
> functionality alone would be sufficient to accomplish the goals
> currently aimed at by your 30kb patch :-).

Ah, I see. Well, sure, as long as "rollback:<message>" is not required
we can easily reduce the patch size dramatically, of course. I've to
investigate to decide whether "ignore" and "abort:<message>" is already
equally sufficient in practice.

                                       Ralf S. Engelschall
                                       address@hidden
                                       www.engelschall.com