Re: [Monotone-devel] automate get_current_revision [was --non-interactive ... ]

[Thomas Keller]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Zbigniew Zagórski schrieb:
> Hmm, sorry for mess i didn't know about that branch. Lot of
> interesting things are hidden there in nvm....

Yeah, I "digged" it out recently after adding it to the "BranchStatuses"
wiki page. I forgot about it myself as well, originally I pretty much
had the same drive to implement it like you have now (and I still have
somehow, but I was distracted with other things for guitone).
Nevertheless nice, the next version of guitone allows restricted commits
then ;)

> Looking at differences:
> 1. Your version fails if there are no changes in workspace. Dunno if
> it's good or not. (after few minutes of thinking it's rather good).

Given the fact that you can't do anything with the revision it spits out
in this case and that all the "new" information you get there is a bogus
new_manifest ID and the format version of the revision format (the
old_revision can easily be queried already by get_base_revision_id), I
think it would be indeed a good idea to put that check in there. I'll
leave that to you (+ the obligatory test), so we don't do that again
both - I have to return to my main work some time today anyways ;)

> 2. I think it's reasonable to limit functionality of get_revision to
> give only revisions form database. (automate_get_revision test needs
> to be updated)

Yep, already did that.

> 3. Code is almost the same ... looks like we copy-pasted from same source ;)

Yay, the copy'n'paste monster!

Thomas.

- --
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHu/0Saf7NlBYNEJIRAgBQAKCclwQQtzHrOSKy3HPjV71tDorgmgCfaIcq
cLtoUc6nlHZGrSggFfBxLIY=
=bElc
-----END PGP SIGNATURE-----