[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Speedup chances
From: |
Christof Petig |
Subject: |
Re: [Monotone-devel] Speedup chances |
Date: |
Mon, 05 May 2008 19:44:40 +0200 |
User-agent: |
Thunderbird 2.0.0.12 (X11/20080227) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Markus Schiltknecht schrieb:
> Hi,
>
> Christof Petig wrote:
>> The problem at hand is the malloc and memset overhead introduced by
>> using a dynamic buffer.
>
> Huh? Why do we use memset there? malloc() hardly makes for a 40%
> speedup, does it?
Botan seems to call memset on buffer free. And since we call hex_decode
some 100k times per OE roster read, this easily adds up.
>> The botan decoder might as well be used by the specialized functions
>> which give 40% speedup, but I was unable to decode the botan manual.
>
> So you are saying it's not botan which is slow, but our use of it,
> calling malloc() and memset() within monotone, before invoking botan,
> right?
I don't know whether botan's hex_decode is slow or fast, but using
dynamic buffering here kills performance.
Christof
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIH0eHng+R+0ucfO0RAq0CAJ9Y9upTZ+h0lEH+FhE0klqZlBhpNgCfWtXc
dkbGPnws98E+WXEp3/fEjgo=
=vXMq
-----END PGP SIGNATURE-----
- Re: [Monotone-devel] Speedup chances, (continued)
- Re: [Monotone-devel] Speedup chances, Markus Schiltknecht, 2008/05/03
- Re: [Monotone-devel] Speedup chances, Christof Petig, 2008/05/04
- Re: [Monotone-devel] Speedup chances, Christof Petig, 2008/05/04
- Re: [Monotone-devel] Speedup chances, Markus Schiltknecht, 2008/05/05
- Re: [Monotone-devel] Speedup chances,
Christof Petig <=
- [Monotone-devel] Re: Speedup chances, Lapo Luchini, 2008/05/05
- Re: [Monotone-devel] Re: Speedup chances, Jack Lloyd, 2008/05/05
- Re: [Monotone-devel] Speedup chances, Eric Anderson, 2008/05/05
- Re: [Monotone-devel] Speedup chances, Markus Schiltknecht, 2008/05/06
- Re: [Monotone-devel] Speedup chances, Eric Anderson, 2008/05/08
- Re: [Monotone-devel] Speedup chances, Jack Lloyd, 2008/05/08
- Re: [Monotone-devel] Speedup chances, Markus Schiltknecht, 2008/05/08
- Re: [Monotone-devel] Speedup chances, Jack Lloyd, 2008/05/08