[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] tests/automate_get_workspace_root broken on MinGW
From: |
Stephen Leake |
Subject: |
Re: [Monotone-devel] tests/automate_get_workspace_root broken on MinGW |
Date: |
Sun, 25 May 2008 01:34:18 -0400 |
User-agent: |
Gnus/5.1008 (Gnus v5.10.8) Emacs/22.1 (windows-nt) |
Timothy Brownawell <address@hidden> writes:
> On Sat, 2008-05-24 at 12:51 -0400, Stephen Leake wrote:
>> tests/automate_get_workspace_root/__driver__.lua does:
>>
>> check(indir("foo",mtn("automate", "get_workspace_root")), 0, true, false)
>> check(qgrep("^"..cwd.."$", "stdout"))
>>
>> That breaks on MinGW; the directory path has backslashes in it, which
>> should be escaped.
>>
>> I couldn't find a 'quote_regexp' Lua function, nor did a quick search
>> find one in pcre/*.
>>
>> Anyway this seems simpler:
>>
>> check(cwd .. '\n' == readfile("stdout"))
>>
>> Is there a reason to prefer 'qgrep' over ' == readfile()'?
>
> For automate we generally want *exact* output, so readfile() is more
> correct. qgrep would be more for checking non-automate commands, which
> tend to have pretty formatting and human-targeted extra chatter that's
> OK to change.
Ok, that's what I thought. My fix is committed.
--
-- Stephe