[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] [PATCH] fix use of hostname from parsed uri
From: |
Stephen Leake |
Subject: |
Re: [Monotone-devel] [PATCH] fix use of hostname from parsed uri |
Date: |
Sat, 27 Sep 2008 01:24:41 -0400 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.2 (windows-nt) |
Roland McGrath <address@hidden> writes:
>> > The test is any push/pull/sync operation using "mtn://server" instead of
>> > "server" (or "mtn://server:port/" instead of "server:port") as the ADDRESS
>> > parameter.
>>
>> I understood this; I was asking you to write an automated test that
>> could be added to the test suite, to ensure that it doesn't get broken
>> in the future.
>
> I understood this. I was hoping that among experienced monotone hackers
> there might be some sympathy for the guy who sent in the fix, and someone
> might take the minute it took to commit the fix and throw in the five more
> minutes someone well-versed in the monotone tree would need to add the
> simple test case. But thanks for the invitation to spend all day trying to
> figure out the monotone test suite setup just to get any useful action on
> fixing something that should always have worked and that any random user
> walking up to use mtn can't fathom wouldn't be entirely reliable and
> thoroughly tested in any SCM that isn't a joke, it's awesome for building
> community spirit.
I think it's always appropriate to _ask_ if the bug submitter can
write a test. For example, I have no idea what your level of expertise
in the mtn testsuite is; asking is the only way to find out.
You could have just said "no, that would be too hard for me; I don't
understand how the test suite works".
I thought the request was phrased quite gently:
>> Is it possible you could write a test case or two for this bug?
Community spirit is a fragile thing.
--
-- Stephe