Re: [Monotone-devel] the changelog editor branch is ready for review

[Thomas Keller]

Am 05.05.2010 07:11, schrieb Derek Scherger:
> On Tue, Apr 20, 2010 at 3:57 PM, Thomas Keller <address@hidden> wrote:
>> And of course I'd remove Revision: and Parent: from the editable area to
>> make it even less verbose, but we've had this discussion before and as I
>> said I'm happy already that my separators made it in ;)
>>
> 
> Yes, you're arguing for removing these non-editable things and including the
> non-editable old branch value. I'm arguing for keeping these and not
> including the old branch value. It's pretty arbitrary either way there's no
> doubt.

Ok, you're right, I was not consistent here. Maybe I thought more of
"only show actual (editable) cert values in the editable area" - both
Parent: and Revision: are clearly not certs at all.

> My rationale for leaving the Revision and Parent headers in is that without
> them the nicely aligned headers look a bit odd because they have extra
> alignment whitespace that is only relevant when those headers do appear in
> the output from log and status and I'd like to keep the display from these
> three commands as similar as possible.

Ok, as I said earlier, I don't want to argue on these two extra lines
too much and I see this as trade-off between consistency with other
command's output and cleanness of the editor's contents now.

>> I think we definitely want to have it for 0.48. And I'm also voting for
>> not discussing this useful feature to death (because then it won't get
>> included at all) - so I'm shutting up now :)
>>
> 
> I appreciate the feedback all the same. All that remains is to update the
> manual to include some examples of the new editor display. I should have
> this done some time this week.

Ok, cool!

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature