Re: [Monotone-devel] RFC: lua output redirection

[Thomas Keller]

Am 08.05.10 07:15, schrieb Stephen Leake:
> Thomas Keller <address@hidden> writes:
>> It would pop up in the progress (p) stream. I'm not sure how lua code is
>> supposed to write basic_io to stdio's main output (m) stream. For
>> non-stdio Lua implementors could still just call io.stdout:write()
> 
> Ok. If we make the assumption that anything written to io.write() is a
> progress message, then I agree that capturing it somehow is more
> important than the details of newlines and stdout vs stderr.
> 
> I think that assumption is reasonable; it's certainly true for my Lua
> code.
> 
> Hmm. I'm not sure that's true in the current tests; does this
> overwriting happen when the mtn tests are running?
> 
> If someone is depending on the current behavior, they can change to
> io.stdout:write().

No, while tester binary uses the same lua wrapper like monotone, it
doesn't uses the lua hooks setup which contains the particular code, so
a print() in a test file still does exactly the same as before.

> Sounds good.

Cool, other opinions?

Thomas.


-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature