Re: [Nano-devel] nanobits3.patch committed

[David Lawrence Ramsey]

--- Chris Allegretta <address@hidden> wrote:
>On Thu, Aug 22, 2002 at 01:49:49PM -0400, David Benbennick wrote:
>> On Thu, Aug 22, 2002 at 05:11:25AM -0700, Chris Allegretta wrote:
>> > ... I'd rather not see a large chunk of the code become static. ...
>> > 
>> > ... let me know what you think about this.
>> 
>> Okay, no more static functions.
>> 
>> I wonder if it is a good idea to include prototypes in proto.h for all
>> non-static functions?  As the code now stands, I could add a function
>> named print1opt to any source file other than nano.c.  There are no
>> compiler errors, but the linker bombs.  By having a prototype for nano.c's
>> version of print1opt, the problem would be caught by the compiler.
>
>This is a very good idea.  It would unpleasant work to do, but if
>no one else does I will do it, assuming I have free time again in the 
>near future.  

I've done it.  All functions have prototypes now (in the
order listed in proto.h), and some functions have been
swapped around to put them in a more consistent order.  I've
tested it with all the --enable options and it seems to work.
(I'll test it some more, though, just to be sure.)


_____________________________________________________________
Sluggy.Net: The Sluggy Freelance Community!

_____________________________________________________________
Promote your group and strengthen ties to your members with address@hidden by 
Everyone.net  http://www.everyone.net/?btn=tag

nanoproto.patch.bz2
Description: Binary data