Re: [Nano-devel] [PATCH] Window resize handling

[Benno Schulenberg]

On Sat, May 16, 2015, at 08:05, Mahyar Abbaspour wrote:
> It doesn't adapt the new size because we block the SIGWINCH signal
> at the beginning of the do_justify() function.

Ah, yes, of course.

> Can we delete unpartition_filestruct() from the regenerate_screen()
> function and let SIGWINCH happen in do_justify() ?

I've tested that, and it appears to work fine.  It's unclear why that
unpartition_filestruct() is in regenerate_screen() anyway; it seems
an odd place for it, and the comment doesn't help.  It is probably a
useless leftover; it stems from revision 2050, and a different handling
of SIGWINCH came around in r3496.


After a bit further testing, I find this problem:
run 'src/nano +11 NEWS', and type:  M-A  <Down>  ^T
(It thinks "lizf" is misspelled and asks to replace it.)

Now make the window narrower and narrower:
  Floating point exception

But I think this is something happening in the statusbar --
I've seen it abbreviate the replacement string in strange ways
-- and doesn't have anything to do with your patch.

(The above is with the internal spell checker, so without
having any speller defined in your .nanorc.)

Benno

-- 
http://www.fastmail.com - Does exactly what it says on the tin