[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH 1/8] add support for gnulib
From: |
Mike Frysinger |
Subject: |
Re: [Nano-devel] [PATCH 1/8] add support for gnulib |
Date: |
Sun, 7 Feb 2016 22:37:11 -0500 |
On 07 Feb 2016 13:23, Benno Schulenberg wrote:
> On Sun, Feb 7, 2016, at 01:03, Mike Frysinger wrote:
> > On a current Linux system, the size of nano is unchanged.
> > We start off with importing only a few modules, although
> > we don't yet delete the fallback logic for them.
> > ---
> > .gitignore | 7 +++++++
> > Makefile.am | 2 +-
> > autogen.sh | 12 ++++++++++++
> > configure.ac | 7 +++++++
> > m4/Makefile.am | 2 +-
> > src/Makefile.am | 4 ++--
> > 6 files changed, 30 insertions(+), 4 deletions(-)
>
> Wow. So simple?
>
> So, before rolling a tarball, all one does is:
>
> GNULIB_SRCDIR=/path/to/repo/of/gnulib/ ./autogen.sh
>
> and all the rest is automatic: the needed files are copied
> over to lib/, a Makefile.am is included, and this makes sure
> the relevant files are also included in DIST. Wow. Easy!
GNULIB_SRCDIR is a semi-common dir, so i tend to export it in my
profile. some projects will autobootstrap a copy locally, but i
don't know if you want to get that crazy.
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -13,6 +13,7 @@ core
> > /ABOUT-NLS
> > /INSTALL
> > /aclocal.m4
> > +/ar-lib
>
> What's ar-lib?
a helper tool automake installs
> > +# gnulib entries
> > +/lib/
> > +/m4/.gitignore
> > +/m4/gnulib-cache.m4
> > +/snippet/
>
> What's in snippet/?
some stuff gnulib installs
> And why's m4/.gitignore needed when the only
> ignored file is already mentioned here?
gnulib installs its own ignore file
> > +dnl Lie about gnulib features we don't use to speed up & shrink down.
> > +
> > +gl_cv_func_printf_infinite_long_double=yes
>
> Hm? What does this do? Where is the lie? What goes
> faster? And what shrinks?
nano doesn't use %Lg (or really any floating point code), so checking for
it is a waste of time, and enabling the gnulib copy of printf just to get
that support increases compile time & compiled size.
-mike
signature.asc
Description: Digital signature
- [Nano-devel] [PATCH 4/8] drop isblank/iswblank fallback functions, (continued)
- [Nano-devel] [PATCH 4/8] drop isblank/iswblank fallback functions, Mike Frysinger, 2016/02/06
- [Nano-devel] [PATCH 5/8] assume regex.h support is always available, Mike Frysinger, 2016/02/06
- [Nano-devel] [PATCH 2/8] drop various str fallback functions, Mike Frysinger, 2016/02/06
- [Nano-devel] [PATCH 7/8] drop glib fallback for snprintf/vsnprintf, Mike Frysinger, 2016/02/06
- Re: [Nano-devel] [PATCH 1/8] add support for gnulib, Mike Frysinger, 2016/02/06
Re: [Nano-devel] [PATCH 1/8] add support for gnulib, Benno Schulenberg, 2016/02/07