Re: [Nano-devel] [PATCH 2/2] use futimens() if available, instead of utime()

[Benno Schulenberg]

Hello Kamil,

When Mike commented (about the futimens stuff) that we ought
to start using gnulib, I thought that this patch would soon
be made superfluous, so I didn't look at it any further.

But today I was rummaging a bit through Redhat's bugzilla,
and thus found an earlier version of your patch
(https://lists.gnu.org/archive/html/nano-devel/2010-11/msg00002.html)
and noticed that your new version contained something
that your earlier version didn't:

> +     /* copy_file() closed the files, make sure 'f' is not used any more. */
> +     f = NULL;

I am not at home in the ecosystem of Redhat, but above addition
seems to be the result of https://bugzilla.redhat.com/show_bug.cgi?id=1177155.

Comment #1 in that bug seems to say it has to do with calling futimens()
on a closed file, but I don't see how that would work.  To me it looks
like it would be good to set f to NULL there even without any of the
futimens changes.  Can you shed some light on what bug the above line
fixes?

Benno

-- 
http://www.fastmail.com - Accessible with your email software
                          or over the web