nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH 07/10] assume regex.h support is always availabl


From: Mike Frysinger
Subject: Re: [Nano-devel] [PATCH 07/10] assume regex.h support is always available
Date: Tue, 21 Feb 2017 16:12:47 -0500

On 21 Feb 2017 21:12, Benno Schulenberg wrote:
> On Tue, Feb 21, 2017, at 19:27, Mike Frysinger wrote:
> > On 21 Feb 2017 18:43, Benno Schulenberg wrote:
> > > Applying: assume regex.h support is always available
> > > error: patch failed: src/search.c:35
> > > error: src/search.c: patch does not apply
> > > error: patch failed: src/utils.c:237
> > > error: src/utils.c: patch does not apply
> > 
> > i rebased on top of c88d7ce530aaac446baae143a2a7e7e29b78bae1.
> 
> That commit is from a month ago.  A few things have changed
> since then, especially is search.c.

i didn't pick that on purpose, it's just last time i did it

> > i can pull & rebase again.
> 
> No, it's fine, I've done it.

*shrug* already done.  and i've got some changes.

> After those ten patches, nano's binary has grown from
> 195K to 203K.  Not much, but still: how come?  Eight
> kilobytes of code is compiled in that we're not using?

when i test locally, code size is unchanged.  off the top of my head,
i'd guess that gnulib detected some bugs in your system and pulled in
fixes/workarounds for them.  just because you're running glibc doesn't
mean it's bug free :).
-mike

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]