Re: [Nano-devel] fixing bug #51040

[Benno Schulenberg]

Op 25-09-2017 om 21:25 schreef Viorel Bota:
> With the new patch 
> (0001-files-check-for-a-changed-disk-file-also-for-savefil.patch)
>
> *Behaviour 1:*
>          if the user uses --tempfile
>          and the file changed on disk
>          and user attempts exit by pressing "^x" and selecting option "Y" (Yes)
>          then the file buffer is written to the disk but nano does not exit.
>
>      This does not feels natural. Since you have to press "^x" a second time to 
> exit nano.

Yes, you're right.  After that "Yes", nano should write the file and exit
immediately.  Please correct the patch to make it do so.

> *Behaviour 2: *
>      As you indicated:
>      if the user uses --tempfile
>      and the file changed on disk
>      and user attempts exit by pressing "^x" and selecting option "N" (No)
>      then nano does nothing exactly as if the user would select "^c" (Cancel)

Yes, I was being chicken.  If the user wants to cancel the ^X, ^C should be
used.  When the user does not want to overwrite the changed disk file, "No"
should discard the buffer and exit.  Please adjust the current patch back to
the behavior that it had when you first sent it.

> *Question 1:*
>      should nano have the same behavior:
>      when using --tempfile or not
>      and the user pressed "^x" then selects option "N" (No)?

Yes.

> *Question 2: *
>      should we make nano discard changes and exit when the user pressed "^x" then 
> select option "N" (No)?

Follows from the first: yes.

Thanks for testing.

Benno