nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH 1/2] new feature: piping (selected) text to an e


From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH 1/2] new feature: piping (selected) text to an external command
Date: Sat, 12 May 2018 13:56:02 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

Op 12-05-18 om 00:15 schreef Marco Diego Aurélio Mesquita:
> +             if (!has_selection && !ISSET(MULTIBUFFER)) {
> +                     openfile->current = openfile->fileage;
> +                     openfile->current_x = 0;
> +                     add_undo(CUT);
> +                     do_cut_text(FALSE, TRUE);
> +                     update_undo(CUT);
> +             }

This is silly duplication.  Merge it into the earlier cutting of text,
as in the attached diff.

And please merge all of these patches into a single one, so that you
don't first make wrong changes and then undo them again.  And make
sure you have whitespace after keywords like 'if'.

Benno

Attachment: merge-the-cuts.diff
Description: Text Data

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]