[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] Incremental search: a new hope.
|
From: |
Marco Diego Aurélio Mesquita |
|
Subject: |
Re: [Nano-devel] [PATCH] Incremental search: a new hope. |
|
Date: |
Sun, 15 Jul 2018 12:01:04 -0300 |
I found some minor problems with the patch sent and fixed them. Namely:
- changed "NOT_FOUND" and "BAD_REGEX" to "Not found" and "Bad regex",
- fixed a comment about a deprecation the slipped during rebase and
- improved the logic to determine when go_looking should be called.
Also, I tested all the cases described in
http://lists.gnu.org/archive/html/nano-devel/2018-01/msg00155.html ,
http://lists.gnu.org/archive/html/nano-devel/2018-02/msg00016.html and
http://lists.gnu.org/archive/html/nano-devel/2018-02/msg00008.html .
Nano behaved correctly in all of them.
Please review it.
0001-Implement-incremental-search.patch
Description: Text Data