Re: [Nano-devel] [PATCH 1/2] new thing: a tools menu that groups together some larger functions

[Benno Schulenberg]

Op 14-05-19 om 04:14 schreef Brand Huntsman:
> The ^T bind is not available without ENABLE_SPELLER.
> 
> #ifdef ENABLE_SPELLER -   add_to_sclist(MMAIN, "^T", 0, do_spell, 0); + 
> add_to_sclist(MMAIN, "^T", 0, offer_tools, 0); #endif

Thanks.  Didn't notice that.

> There is no function name to rebind the tools menu in nanorc.

I didn't think that far ahead.  Will add it in a separate commit.

> The "Choose a tool" should probably be left aligned. Your eye is drawn to the 
> left side for other menus and this one has nothing there.

This is actually on purpose.  I had it left aligned at first with trailing dots,
but didn't like it: it still looked too much like a prompt.  Now it looks like
a header, a title, which means that the real stuff will be underneath it.  But
indeed, when the help lines are hidden...

> Maybe the nohelp M-X toggle could be bound by default in the tools menu (and 
> maybe other prompts so you don't have close prompt, enable help and re-open 
> prompt).

That is good idea.  But it will have to be a "blind" binding: I don't want
to show M-X in every menu and every help text.

> And "Choose a tool... press M-X for list" could be used if help bar is 
> hidden.
Don't like that much.  People shouldn't switch off the help lines when
they don't know nano fully yet, and for those that do know, the "press
something for list" is superfluous.  But true, this is something new,
and the experienced users will not switch the help lines just because
they upgraded to a newer nano.

Benno

signature.asc
Description: OpenPGP digital signature