Re: [PATCH] syntax: gentoo: some cleaning and modernizing

[Benno Schulenberg]

Op 24-06-2021 om 15:28 schreef David Michael:
> It looks like the games functions were just removed last month, so
> yes, they could be dropped.

Dropped, since its eclass has been deprecated for five years:
    https://bugs.gentoo.org/574082

>> Also, "dojar" and "dopython" get highlighted, but I don't see them in the 
>> specs
>> either.  Obsolete too?
> 
> They seem to have been builtins long ago that were replaced by other
> methods, so they can be dropped.

Dropped.

With these changes I've pushed your patch:
    https://git.savannah.gnu.org/cgit/nano.git/commit/?id=7b4a835d

>  Note that some of the other
> highlighted install functions (dopam, domenu, etc.) will not be found
> in the spec either, but they are defined in eclasses.

I do see domenu and doicon in the eclasses, but not dopam -- only dopamd,
dopammod and dopamsecurity.  So probably 'dopam' should be dropped?  And
maybe 'docron' and some others should be added instead?

Looking further, I don't see 'epause', 'ebeep' and 'epunt_cxx' anywhere.
Should they be dropped too?  If 'ecvs_clean' and 'esvn_clean' are colored,
why not also 'egit_clean'?  Or maybe these should not be colored at all
(when they are only rarely used, for example)?

The "inherit.*" regex looks too broad: it will color also the semicolons
that occur after its arguments in several eclasses.

And probably there's other stuff that needs adjustment.  So you may want
to supply a further patch?

Benno

OpenPGP_signature
Description: OpenPGP digital signature