Re: [PATCH v2] startup: add support for <file>:<line> format

[Benno Schulenberg]

Op 26-02-2023 om 01:58 schreef Benjamin Valentin:
> +               {
> +                       char *filename = argv[optind++];
> +
> +                       /* search for : to open file on a specific line */

Adjust the comment style to that of the rest of nano: start with a
capital, and end with a period.


> +                       char *colon = filename;

Keep declarations together -- put it right after the previous one.


> +                               /* if file starts with : skip that */
> +                               if (colon == filename) {
> +                                       ++colon;
> +                                       continue;
> +                               };

When starting the search from filename + 1, this fragment is unneeded.


> +                               if (*(colon - 1) == '\\') {
> +                                       size_t len = strlen(colon);
> +                                       memmove(colon - 1, colon, len);
> +                                       colon[len - 1] = 0;

When moving strlen(colon) + 1 bytes, the terminating zero is included,
and you don't need to poke it, and don't need an additional variable.


> +                               /* if parsing succeeds, cut of the line suffix 
> */
> +                               if (parse_line_column(colon + 1, &givenline, 
> &givencol))
> +                                       *colon = 0;

But if parsing fails, maybe there is a colon with proper numbers further
down the name.  So it should continue in that case.  That will allow
using filenames with embedded colons without needing to escape them
in most cases.

If you really wish your patch to be included in nano, you should
sign it off, as it says in README.hacking.

Benno

OpenPGP_signature
Description: OpenPGP digital signature