nmh-workers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Make test-mhical pass with BSD yacc.


From: David Levine
Subject: Re: [PATCH] Make test-mhical pass with BSD yacc.
Date: Sun, 20 Sep 2020 11:50:59 -0400

Ralph wrote:

> it could be like some of the other tests and grep directly.  Something
> like
>
>     check "$expected" "$actual"
>     re='mhical: syntax error.* " this line is not folded"'
>     grep -q "$re" "$actual_err"
>     grep -qv "$re" "$actual_err" | grep -q ^ && false
>
> or
>
>     test `wc -l <"$actual_err"` -eq 1

I just committed a fix using that approach.  Thanks, Eric and Ralph.

> Anyone here know why the printf a little earlier is wrapped in
> set +e...set -e?  Perhaps something to do with the lack of trailing LF?

Good catch.  The test author assumed that the exit status from mhical(1)
would reflect the parse failure.  It didn't, but I just committed a fix
for that.

David



reply via email to

[Prev in Thread] Current Thread [Next in Thread]