[Octave-bug-tracker] [bug #30519] missing "units" listener for conversion of values

[David Bateman]

Follow-up Comment #1, bug #30519 (project octave):

Ok I fell into this on with the legend code, though I don't understand the
need for the listener functions here. As far as I can see a listener would
only be needed if for example changing the "units" property of an axis changed
the "units" property of the figure it is associated with. What seems to be
missing to me is that the {get|set}_outerposition and {get|set}_position
methods of the axes class should call the convert_position function to handle
the units property. The same should be done with the font* and paperposition
properties for the other classes you mentioned.

The attached patch tries to address the "units" properties for the axes class
and it fixes the problem I had. Does it do the right thing? Am I missing
something that would mean that the listeners are needed?

If you think this is the right approach I'll fix the other classes and work
this up into a changeset.

D.


(file #21388)
    _______________________________________________________

Additional Item Attachment:

File name: patch.units                    Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30519>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/