[Octave-bug-tracker] [bug #31536] demos for patch and isosurface fail

[Rik]

Update of bug #31536 (project octave):

              Item Group:                    None => Incorrect Result       
                  Status:                    None => Confirmed              

    _______________________________________________________

Follow-up Comment #1:

Using 'hg bisect' I find the problem was introduced in this changeset:

changeset:   11160:131d56b6d9a3
user:        David Bateman <address@hidden>
date:        Thu Oct 28 01:56:14 2010 +0200
summary:     Set cdata from facevertexcdata and visa versa for patch at all
times

I've only briefly glanced at your patch.  We should definitely avoid indexing
into null arrays, which is what your patch does.  However it does it for only
2 of the 4 occurrences of this code construct.  Would it be better to do it
for all 4?  Also, the strcmp functions now work perfectly well on cell arrays
so I think the code could eliminate the anonymous function call for
legibility.  Sample below:

Original:
idx = find (cellfun (@(x) strcmpi (x, "facevertexcdata"), args))(end) + 1;
Proposed:
idx = find (cellfun (@(x) strcmpi (x, "facevertexcdata"), args), 1, "last") +
1;
My Suggestion:
idx = find (strcmpi (args, "facevertexcdata"), 1, "last") + 1;


Otherwise, the patch works for me.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?31536>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/