[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #46054] make rules for *.df ignore user CXXFLA
From: |
Carnë Draug |
Subject: |
[Octave-bug-tracker] [bug #46054] make rules for *.df ignore user CXXFLAGS |
Date: |
Sat, 26 Sep 2015 15:51:58 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Iceweasel/38.2.1 |
URL:
<http://savannah.gnu.org/bugs/?46054>
Summary: make rules for *.df ignore user CXXFLAGS
Project: GNU Octave
Submitted by: carandraug
Submitted on: Sat 26 Sep 2015 15:51:57 GMT
Category: Configuration and Build System
Severity: 3 - Normal
Priority: 5 - Normal
Item Group: Build Failure
Status: Patch Submitted
Assigned to: None
Originator Name:
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Release: dev
Operating System: GNU/Linux
_______________________________________________________
Details:
The rules for df do not make use of the user defined CXXFLAGS. This is working
fine in the stable branch. The reason is that these got dropped when removing
the recursive make:
http://hg.savannah.gnu.org/hgweb/octave/rev/0ce7d8303152#l5.534
http://hg.savannah.gnu.org/hgweb/octave/rev/0ce7d8303152#l9.362
http://hg.savannah.gnu.org/hgweb/octave/rev/0ce7d8303152#l10.265
The attached changeset fixes the issue. However, I also noticed that these 3
rules are quite similar among them so maybe there's a better way to do this
that would avoid code duplication?
One of this issue was causing a build failure, and I found the other two by
running the following on the build tree (but maybe this is still missing some
other cases?)
$ grep -nrP -A 2 '_CXXLAGS\) (?!\$\(CXXFLAGS\))
$ grep -nrP -A 2 '_CLAGS\) (?!\$\(CFLAGS\))
$ grep -nrP -A 2 '_FFLAGS\) (?!\$\(FFLAGS\))
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Sat 26 Sep 2015 15:51:57 GMT Name: df-cxxflags.cset Size: 2kB By:
carandraug
<http://savannah.gnu.org/bugs/download.php?file_id=34990>
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?46054>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #46054] make rules for *.df ignore user CXXFLAGS,
Carnë Draug <=