[Octave-bug-tracker] [bug #44187] Bugs and modifications in print() with gnuplot graphics toolkit

[Ben Abbott]

Follow-up Comment #71, bug #44187 (project octave):

I've pushed two changesets.

http://hg.savannah.gnu.org/hgweb/octave/rev/165ba7463ca9

http://hg.savannah.gnu.org/hgweb/octave/rev/793886a00c3b

Regarding the mono/color for gnuplot and the trouble with axes/figure
background colors for "mono", these can easily be handled by having Octave
convert from "color" to "mono" in print.m as is done for OpenGL.

Since I prefer that print.m and __print_parse_opts__.m include not toolkit
specific code, I'd like fix both the mono/color problems and the background
color problems by having print.m handle the color to mono conversion.

++
diff --git a/scripts/plot/util/print.m b/scripts/plot/util/print.m
--- a/scripts/plot/util/print.m
+++ b/scripts/plot/util/print.m
@@ -379,8 +379,7 @@ function print (varargin)
       set (h, "linestyle", linestyle);
     endif
 
-    if (opts.use_color < 0
-        && ! strcmp (get (opts.figure, "__graphics_toolkit__"), "gnuplot"))
+    if (opts.use_color < 0)
       color_props = {"color", "facecolor", "edgecolor", "colormap"};
       for c = 1:numel (color_props)
         h = findall (opts.figure, "-property", color_props{c});
--

The gnuplot toolkit will then need to be modified to ignore opts.use_color.
This would reduce complexity and simplify maintenance. Thoughts? 

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44187>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/