[Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files

[Lachlan Andrew]

Follow-up Comment #2, bug #41298 (project octave):

Oliver, I've had a quick look at the code, and have some initial comments. 
I'll try to review it properly soon.

Why do you not overwrite existing tests?  ("if (exist (full_tst_file)),
continue, endif")  This may make it hard for someone who is trying to tweak
the tests.  Most make processes just overwrite existing files.

I like it when automatically generated files say both the source they were
generated from and also the program that did the generation.

In the change to test.m, why do you add ".cc-tst" but not ".tst"?

The commit message should start with a summary line that doesn't start with "*
<filename>", but summarises the change and mentions the bug number.  This also
applies to the patch for bug #41215.

Some trivial points are:
- the first hunk has indentation of four spaces instead of two.
- When {...} is used to denote a subscript, I think the coding standard says
there shouldn't be a space before {.
- Why do you use "not ()" instead of "!"?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?41298>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/