[Octave-bug-tracker] [bug #52473] "lu" crashes on current stable branch

[John W. Eaton]

Follow-up Comment #8, bug #52473 (project octave):

There is still one more issue that needs to be fixed.  In the dev sources, we
have the following in liboctave/array/lu.h:


      // The result of getp is passed to other Octave Matrix functions,
      // so we use octave_idx_type.
      Array<octave_idx_type> getp (void) const;

      T a_fact;
      T l_fact;

      // This is internal storage that is passed to Fortran,
      // so we need a Fortran INTEGER.
      Array<octave_f77_int_type> ipvt;


The comment is right that ipvt should be Array<F77_INT> but that getp should
return Array<octave_idx_type>.  That change is trivial, but then some
additional fixes are needed to properly copy values when these types are not
the same, which is the case on most systems today that have 64-bit pointers
and BLAS libraries that use 32-bit indexing.

I'll take a look at doing that next.  Just reporting here in case  I don't get
back to this.

Also, I'm not sure how this is working properly with default Octave.  Hmmm.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52473>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/