[Octave-bug-tracker] [bug #54231] GUI attempts to open file for function declared at top-level

[Rik]

Follow-up Comment #13, bug #54231 (project octave):

@Torsten: In the patch, is there a specific reason to convert to Qstring from
std::string in order to compare it to a constant?  The C++ std::string class
implements the '==' operator.


+    QString type = QString::fromStdString (
+                    map.contents ("type").data ()[0].string_value ());
+    if (type == QString ("command-line function"))


Seems like you could just keep type as std::string.


+    std::string type = map.contents ("type").data ()[0].string_value ());
+    if (type == "command-line function")





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54231>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/