[Octave-bug-tracker] [bug #54299] HDF5 file I/O unit tests fail or crash Octave

[Markus Mützel]

Update of bug #54299 (project octave):

                  Status:         Patch Submitted => Ready For Test         

    _______________________________________________________

Follow-up Comment #10:

Sorry. I missed these.
The function get_ASCII_filename can help if a function relying on the char
WinAPI (MS calls that the ANSI WinAPI) tries to *read* from a location that is
only accessible with the wchar WinAPI (Unicode WinAPI in MS speak). It cannot
help if a function relying on the ANSI WinAPI tries to *create* a file in a
location that is only accessible with the Unicode WinAPI.

The FIXME outlines a way that might work for these file locations with
H5Fcreate. However, I couldn't figure out how I could trigger these parts of
the code. So I left it with the FIXME.
With your change H5Fcreate might create the file in a wrong location or with a
wrong name.
I now realize that a possible test is:

a = 5;
save täst.mat a -hdf5


I might have a look at this later (different bug).


With respect to the other similar change in load-save.cc:

@@ -319,11 +323,11 @@ get_file_format (const std::string& fnam
     return LS_HDF5;
 #endif
 
 #if defined (HAVE_ZLIB)
-  use_zlib = check_gzip_magic (fname);
+  use_zlib = check_gzip_magic (ascii_fname);
 #else
   use_zlib = false;
 #endif
 
   if (! use_zlib)
     {


I tried to do the "conversion" as close as possible to the actual operation on
the file system. So I did the "conversion" to an ASCII file name inside
"check_gzip_magic". Since this is the only place where "check_gzip_magic" is
called, we could remove "get_ASCII_filename" from there and do the above
change instead. What is your opinion?


In the meantime I pushed the rest of your changes here to fix the immediate
issue:
http://hg.savannah.gnu.org/hgweb/octave/rev/ca413f326224


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54299>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/