|
From: | Rik |
Subject: | [Octave-bug-tracker] [bug #55023] gnuplot_binary test fails if there's no gnuplot and leaves incorrect configuration |
Date: | Wed, 14 Nov 2018 13:13:19 -0500 (EST) |
User-agent: | Mozilla/5.0 (X11; Linux i586; rv:31.0) Gecko/20100101 Firefox/31.0 |
Follow-up Comment #7, bug #55023 (project octave): The point I wanted to make is that an unwind_protect/unwind_protect_cleanup is not the optimal strategy. The current set of tests already restores the original value of gnuplot_binary, so there is no need to run cleanup code every time which repeats that. On the other hand, if the tests fail for any reason then you do want to restore the original values. This calls out for a try/catch strategy. _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?55023> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |