[Octave-bug-tracker] [bug #54219] Dynamic detection of JVM on macOS

[Mike Miller]

Follow-up Comment #14, bug #54219 (project octave):

This patch still has some significant problems and needs some more work before
it can be pushed.

The first patch introduces a new class in the octave::sys namespace and
OCTAVE_API, but installs it in libinterp. However, the entire octave::sys
namespace currently lives under liboctave and we should keep it that way. Can
the class live in liboctave? If it depends on other components in
liboctinterp, then it has to stay in liboctinterp, and so it shouldn't be
declared in the octave::sys namespace, and it should use OCTINTERP_API
instead.

Further, the new files oct-proc.{cc,h} names are confusing, similar to
oct-procbuf.{cc,h}. And the copyright statement lists jwe as the author, which
isn't true as far as I can see.

For the second patch, have you looked at merging your new functionality with
the "get_jvm_lib_path_in_subdir" function that has already been added and
tested on other operating systems?

The file name "/usr/libexec/java_home" should be pulled out as a #define or a
string constant instead of written twice.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54219>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/