[Octave-bug-tracker] [bug #55397] test imwrite error with address sanitizer

[Dmitri A. Sergatskov]

Follow-up Comment #13, bug #55397 (project octave):

Do not see any change:


octave:1> imwrite (1, "filename", "junk")
warning: imwrite: unlisted image format junk (see imformats).  Trying to save
anyway.
warning: called from
    imwrite at line 115 column 5
=================================================================
==29911==ERROR: AddressSanitizer: heap-use-after-free on address
0x6250000399f8 at pc 0x7f74a87db2dd bp 0x7ffc45c8bbe0 sp 0x7ffc45c8b388
READ of size 5 at 0x6250000399f8 thread T0
    #0 0x7f74a87db2dc  (/lib64/libasan.so.5+0xa22dc)
    #1 0x7f74a3edd7b0 in GetLocaleExceptionMessage
(/lib64/libGraphicsMagick-Q16.so.3+0xa97b0)
    #2 0x7f74a3eddc9e in ThrowLoggedException
(/lib64/libGraphicsMagick-Q16.so.3+0xa9c9e)
    #3 0x7f74a3ec2103 in WriteImage
(/lib64/libGraphicsMagick-Q16.so.3+0x8e103)
    #4 0x7f74a3ec235a in WriteImages
(/lib64/libGraphicsMagick-Q16.so.3+0x8e35a)
    #5 0x7f74a7551829 in void
Magick::writeImages<__gnu_cxx::__normal_iterator<Magick::Image*,
std::vector<Magick::Image, std::allocator<Magick::Image> > >
>(__gnu_cxx::__normal_iterator<Magick::Image*, std::vector<Magick::Image,
std::allocator<Magick::Image> > >,
__gnu_cxx::__normal_iterator<Magick::Image*, std::vector<Magick::Image,
std::allocator<Magick::Image> > >, std::__cxx11::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&, bool)
(/home/dima/src/octave/gcc_asan/libinterp/.libs/liboctinterp.so.6+0x1829829)
    #6 0x7f74a752830a in write_file
../libinterp/corefcn/__magick_read__.cc:1446
    #7 0x7f74a752ae89 in F__magick_write__(octave_value_list const&, int)
../libinterp/corefcn/__magick_read__.cc:1632
    #8 0x7f74a6ff4984 in octave_builtin::call(octave::tree_evaluator&, int,
octave_value_list const&) ../libinterp/octave-value/ov-builtin.cc:65
    #9 0x7f74a7463ee2 in
octave::tree_evaluator::visit_index_expression(octave::tree_index_expression&)
../libinterp/parse-tree/pt-eval.cc:2008
    #10 0x7f74a749f428 in
octave::tree_index_expression::accept(octave::tree_walker&)
../libinterp/parse-tree/pt-idx.h:102
<<<...>>>



Here is what I did to 

../libinterp/corefcn/__magick_read__.cc


void static
write_file (const std::string& filename,
            const std::string& ext,
            std::vector<Magick::Image>& imvec)
{
  //try
    {
      Magick::writeImages (imvec.begin (), imvec.end (), ext + ':' +
filename);
    }
  /*catch (Magick::Warning& w)
    {
      warning ("Magick++ warning: %s", w.what ());
    }
  catch (Magick::ErrorCoder& e)
    {
      warning ("Magick++ coder error: %s", e.what ());
    }
  catch (Magick::Exception& e)
    {
      error ("Magick++ exception: %s", e.what ());
    }
    */
}





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55397>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/