octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #55525] verLessThan() is unimplemented


From: Pantxo Diribarne
Subject: [Octave-bug-tracker] [bug #55525] verLessThan() is unimplemented
Date: Sun, 20 Jan 2019 12:20:50 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Follow-up Comment #2, bug #55525 (project octave):

We have an Octave specific function "compare_versions". It would probably make
sense to use it for the version string comparison since it handles other
characters like "+".

Other comments:
* Since loops are very slow in Octave we try to vectorize codes as much as
possible. The code could be rewritten to something like

v = ver ();
idx = strcmp ({v.Name}, package);
if (! any (idx))
  error ("verLessThan(): PACKAGE ""%s"" is not installed.", package);
endif

out = compare_versions ({v.Version}{idx}, version, "<");


* Conditions in "if" or "while" statements should be surrounded with
parenthesis
* error/warning strings are prepended with the function name.
* There is a typo, "datenum" should be replaced by "verLessThan" in the doc
string.

I changed the item group, since "Matlab Compatibility" is reserved for already
implemented features that behave differently in Octave and Matlab.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55525>

_______________________________________________
  Message posté via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]