octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #55501] subsequent calls to "help @sym/beta" g


From: John W. Eaton
Subject: [Octave-bug-tracker] [bug #55501] subsequent calls to "help @sym/beta" gives "help beta" text
Date: Mon, 21 Jan 2019 18:26:17 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Follow-up Comment #12, bug #55501 (project octave):

Oops, I didn't use the character position correctly in the first changeset. 
Try the one posted here instead.

For classdef, I think it "works" about the same as before:


 octave:1> __which__ ("@inputParser/addRequired")
ans =

  scalar structure containing the fields:

    name = @inputParser/addRequired
    file = 
    type = 


I see a couple of problems with what is happening in help_system::which. 
First, if the classdef file (in this case, inputParser.m) has not yet been
parsed, then a call like


symtab.find_method ("addRequired", "inputParser");


doesn't cause it to be parsed, so it falls back on looking in the load path
and somehow returns the incorrect result shown above.

If the classdef file has been parsed, then symbol_table::find_method returns a
valid object, but it is an octave_classdef_meta object, not an octave_function
object that contains the addRequired method.

So some additional work is needed to properly handle classdef, but that was
true with 4.4.1 as well.  At least with the patch that I'm proposing, I think
things are working as well as before, so I would no longer count this as a
regression.


(file #46065)
    _______________________________________________________

Additional Item Attachment:

File name: diffs-1.txt                    Size:1 KB


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55501>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]