octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #55525] verLessThan() is unimplemented


From: Rik
Subject: [Octave-bug-tracker] [bug #55525] verLessThan() is unimplemented
Date: Wed, 23 Jan 2019 12:10:08 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko

Update of bug #55525 (project octave):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #9:

I made some additional improvements.  See cset
https://hg.savannah.gnu.org/hgweb/octave/rev/eaebee6d4f56.  The commit message
was:


* verLessThan.m: Use standard documentation phrasing for a function which
returns true/false.  Use @qcode instead of @code for strings in
documentation.
Use standard variable name "retval" for output.  Validate number of input
arguments to function.  Use rows() rather than "size (..., 1)" for clarity.
Capitalize input variable names in error() strings.  Do not end error strings
with a period.  Use single quotes for strings containing double quotes to
avoid
the unclarity of doubling '"'.  Add input validation BIST tests for number of
arguments.

* __unimplemented__.m: Remove verLessThan from list of unimplemented
functions.


Thanks Andrew for coding this up.  I know there is a steep learning curve
associated with programming for Octave core, so I want to acknowledge that and
say that it does get easier.

Marking as fixed and closing report.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55525>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]