octave-bug-tracker
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #52475] ode15 is not compatible with SUNDIALS

From: Carlo de Falco
Subject: [Octave-bug-tracker] [bug #52475] ode15 is not compatible with SUNDIALS >= 3.0.0
Date: Tue, 12 Mar 2019 06:40:07 -0400 (EDT)
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:65.0) Gecko/20100101 Firefox/65.0 
Follow-up Comment #73, bug #52475 (project octave):

jwe, thanks again for your help.

the issue with including klu.h is known and was discussed before below.

with sundials 4.1.0, though, it should be solved, as now __ode15__.cc has


#  if defined (HAVE_SUNLINSOL_SUNLINSOL_KLU_H)
#    if defined (HAVE_KLU_H)
#      include <klu.h>
#    endif
#    if defined (HAVE_KLU_KLU_H)
#      include <klu/klu.h>
#    endif
#    if defined (HAVE_SUITESPARSE_KLU_H)
#      include <suitesparse/klu.h>
#    endif
#    if defined (HAVE_UFPARSE_KLU_H)
#      include <ufsparse/klu.h>
#    endif
#    include <sunlinsol/sunlinsol_klu.h>
#  endif


and sunlinsol/sunlinsol_klu.h uses an include guard 
to not include klu.h if it was already included.

Anyway I agree we should apply this changes now and 
then continue changes in the main repo.

Should I push to stable or default?

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?52475>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/
reply via email to
[Prev in Thread] Current Thread [Next in Thread]