[Octave-bug-tracker] [bug #55909] Performance of hist

[John W. Eaton]

Follow-up Comment #1, bug #55909 (project octave):

When I run the tests on your new version I see the following:


***** test <*47707>
 y = [1  9  2  2  9  3  8  9  1  7  1  1  3  2  4  4  8  2  1  9  4  1 ...
      2  3  1  1  6  5  5  3  9  9  1  1  8  7  7  2  4  1];
 [n, x] = hist (y, 10);
 [nn, xx] = hist (uint8 (y), 10);
 assert (nn, n);
 assert (xx, x);

 ## test again with N > 30 because there's a special case for it
 [n, x] = hist (y, 35);
 [nn, xx] = hist (uint8 (y), 35);
 assert (nn, n);
 assert (xx, x);
!!!!! regression: https://octave.org/testfailure/?47707
ASSERT errors for:  assert (nn,n)

  Location  |  Observed  |  Expected  |  Reason
    (5)           0            6         Abs err 6 exceeds tol 0 by 6
    (9)           0            4         Abs err 4 exceeds tol 0 by 4
    (14)          0            4         Abs err 4 exceeds tol 0 by 4
    (18)          0            2         Abs err 2 exceeds tol 0 by 2
    (22)          0            1         Abs err 1 exceeds tol 0 by 1
    (27)          0            3         Abs err 3 exceeds tol 0 by 3
    (31)          0            3         Abs err 3 exceeds tol 0 by 3
    (35)          29           6         Abs err 23 exceeds tol 0 by 2e+01
PASSES 25 out of 26 tests


I'm attaching a diff relative to the version at hg id ba0c9e84f6a8 after
making some style changes.  Can you please base any future changes on that? 
It would also be best to upload patches instead of whole new versions.  If you
can't do that for some reason, then please also indicate which version you
started with so that someone else can generate diffs.  I know that hist isn't
changing rapidly, but it's useful to use diffs anyway to ensure that we aren't
undoing some other changes or making some unwanted change by simply replacing
a file with a completely new one.

BTW, for changes before we started using Mercurial, you have to look in the
files in the etc/OLD-ChangeLogs directory to find who really mad the change. 
The info from the imported CVS files is not accurate as only a few people had
commit access and we did those under our own IDs instead of attempting to
track the Ids of the people who submitted patches.  Here's the entry for the
one to switch methods based on number of bins:


2003-05-05  Andy Adler  <address@hidden>

        * plot/hist.m: Improve performance by using different algorithms
        depending on number of bins.


(file #46519)
    _______________________________________________________

Additional Item Attachment:

File name: hist-diffs.txt                 Size:2 KB
    <https://savannah.gnu.org/file/hist-diffs.txt?file_id=46519>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55909>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/