[Octave-bug-tracker] [bug #55741] build with '-Woverloaded-virtual' emits many warnings indicating problems

[Andrew Janke]

Follow-up Comment #8, bug #55741 (project octave):

A few more warnings found under clang on macOS 10.14.3 with Xcode 10.1:

A C linkage issue in oct-sparse:


In file included from ../../octave/liboctave/util/oct-sparse.h:75:
/usr/local/include/cs.h:442:14: warning: 'cs_ci_house' has C-linkage
specified, but returns user-defined type 'cs_complex_t' (aka
'complex<double>') which is incompatible with C [-Wreturn-type-c-linkage]
cs_complex_t cs_ci_house (cs_complex_t *x, double *beta, int n) ;
             ^
/usr/local/include/cs.h:582:14: warning: 'cs_cl_house' has C-linkage
specified, but returns user-defined type 'cs_complex_t' (aka
'complex<double>') which is incompatible with C [-Wreturn-type-c-linkage]
cs_complex_t cs_cl_house (cs_complex_t *x, double *beta, cs_long_t n) ;
             ^


Non-prototype function declarations pulled in from readline:


n file included from /usr/local/opt/readline/include/readline/readline.h:36:
/usr/local/opt/readline/include/readline/rltypedefs.h:35:22: warning: this
function declaration is not a prototype [-Wstrict-prototypes]
typedef int Function () __attribute__ ((deprecated));
                     ^
                      void
/usr/local/opt/readline/include/readline/rltypedefs.h:36:24: warning: this
function declaration is not a prototype [-Wstrict-prototypes]
typedef void VFunction () __attribute__ ((deprecated));
                       ^
                        void
/usr/local/opt/readline/include/readline/rltypedefs.h:37:26: warning: this
function declaration is not a prototype [-Wstrict-prototypes]
typedef char *CPFunction () __attribute__ ((deprecated));
                         ^
                          void
/usr/local/opt/readline/include/readline/rltypedefs.h:38:28: warning: this
function declaration is not a prototype [-Wstrict-prototypes]
typedef char **CPPFunction () __attribute__ ((deprecated));
                           ^
                            void
In file included from ../../octave/liboctave/util/oct-rl-edit.c:32:
/usr/local/opt/readline/include/readline/readline.h:398:23: warning: this
function declaration is not a prototype [-Wstrict-prototypes]
extern int rl_message ();
                      ^
                       void


Some old-style casts:


../../octave/libinterp/dldfcn/__delaunayn__.cc:215:15: warning: use of
old-style cast [-Wold-style-cast]
              FOREACHvertex_ (facet->vertices)
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/libqhull/libqhull.h:950:34: note: expanded from macro
'FOREACHvertex_'
#define FOREACHvertex_(vertices) FOREACHsetelement_(vertexT, vertices,vertex)
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/libqhull/qset.h:139:24: note: expanded from macro
'FOREACHsetelement_'
          variable##p= (type **)&((set)->e[0].p); \
                       ^        ~~~~~~~~~~~~~~~~


Some old style casts that look like they're pulled in from the portaudio
library:


../../octave/libinterp/dldfcn/audiodevinfo.cc:59:12: warning: use of old-style
cast [-Wold-style-cast]
    return paInt8;
           ^~~~~~
/usr/local/Cellar/portaudio/19.6.0/include/portaudio.h:491:27: note: expanded
from macro 'paInt8'
#define paInt8           ((PaSampleFormat) 0x00000010) /**< @see
PaSampleFormat */
                          ^                ~~~~~~~~~~
../../octave/libinterp/dldfcn/audiodevinfo.cc:61:12: warning: use of old-style
cast [-Wold-style-cast]
    return paInt16;
           ^~~~~~~
/usr/local/Cellar/portaudio/19.6.0/include/portaudio.h:490:27: note: expanded
from macro 'paInt16'
#define paInt16          ((PaSampleFormat) 0x00000008) /**< @see
PaSampleFormat */
                          ^                ~~~~~~~~~~
../../octave/libinterp/dldfcn/audiodevinfo.cc:63:12: warning: use of old-style
cast [-Wold-style-cast]
    return paInt24;
           ^~~~~~~
/usr/local/Cellar/portaudio/19.6.0/include/portaudio.h:489:27: note: expanded
from macro 'paInt24'
#define paInt24          ((PaSampleFormat) 0x00000004) /**< Packed 24 bit
format. @see PaSampleFormat */
                          ^                ~~~~~~~~~~
../../octave/libinterp/dldfcn/audiodevinfo.cc:65:12: warning: use of old-style
cast [-Wold-style-cast]
    return paInt32;
           ^~~~~~~
/usr/local/Cellar/portaudio/19.6.0/include/portaudio.h:488:27: note: expanded
from macro 'paInt32'
#define paInt32          ((PaSampleFormat) 0x00000002) /**< @see
PaSampleFormat */
                          ^                ~~~~~~~~~~
../../octave/libinterp/dldfcn/audiodevinfo.cc:67:12: warning: use of old-style
cast [-Wold-style-cast]
    return paFloat32;
           ^~~~~~~~~
/usr/local/Cellar/portaudio/19.6.0/include/portaudio.h:487:27: note: expanded
from macro 'paFloat32'
#define paFloat32        ((PaSampleFormat) 0x00000001) /**< @see
PaSampleFormat */
                          ^                ~~~~~~~~~~
  CXX      libinterp/dldfcn/colamd_la-colamd.lo



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55741>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/