[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #56419] Implementation of newline
From: |
Rik |
Subject: |
[Octave-bug-tracker] [bug #56419] Implementation of newline |
Date: |
Tue, 4 Jun 2019 13:06:19 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko |
Update of bug #56419 (project octave):
Status: Patch Reviewed => Fixed
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #6:
I checked in your patch here
(https://hg.savannah.gnu.org/hgweb/octave/rev/f26b13c80e45). You can take a
look, but I made a few changes to convert it from just a patch to a full
changeset.
First, I used your name and e-mail as the author in order to give you credit.
Second, I added a commit message which listed the changes made.
Third, I added the function to the list of new functions for Octave 6.0 in the
NEWS file so that people will discover it. Fourth, I also added the
documentation string to the manual in the chapter on Strings. Fifth, I added
a semicolon to the %!error BIST test so that it wouldn't print out unnecessary
information when run with 'test strfns.cc'. Sixth, I added an example in the
documentation to show how to use newline() to concated two single lines of
text in to a multi-line piece of text.
This is just so you have an idea of what happens behind the scenes. I know
it's a lot to learn, but it does become easier to contribute after a few
patches.
Marking as fixed and closing report.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?56419>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/