[Octave-bug-tracker] [bug #57049] Mac build failure: CFLocaleCopyCurrent from CoreFoundation not found

[Andrew Janke]

Follow-up Comment #18, bug #57049 (project octave):

The more I look into this, the more I think it is an issue with gnulib's
autoconf stuff.

I think we can fix it by patching gnulib's setlocale.m4, as it sits in
Octave's own m4/ directory.


$ diff -c gnulib/m4/setlocale.m4 m4/setlocale.m4
*** gnulib/m4/setlocale.m4      2019-11-03 12:05:39.000000000 -0500
--- m4/setlocale.m4     2019-11-03 12:44:47.000000000 -0500
***************
*** 20,25 ****
--- 20,29 ----
        esac
        ;;
    esac
+
+   dnl Sometimes, on Mac OS X, libintl requires linking with CoreFoundation.
+   gt_INTL_MACOSX
+
  ])

  # Prerequisites of lib/setlocale.c.


What's the right way to patch our customized gnulib during the Octave build
process? As I understand it, the files in m4/ are copied in during the
"./bootstrap" part of the Octave build process. I don't see a patching step
anywhere in there. Maybe it could be added in bootstrap_post_import_hook() in
bootstrap.conf? (How would it know to only do the patching one time (the first
time the file is copied), though?)

As an alternative, if we started using the gnulib gettext module, then it
would pull in CoreFoundation correctly as a side effect. But that doesn't seem
to be a Good Way to do it, since we don't actually need gettext's
functionality.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57049>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/