[Octave-bug-tracker] [bug #57228] [octave forge] (nan) fails to build with undefined references in Octave 5 when LDFLAGS is set

[Mike Miller]

URL:
  <https://savannah.gnu.org/bugs/?57228>

                 Summary: [octave forge] (nan) fails to build with undefined
references in Octave 5 when LDFLAGS is set
                 Project: GNU Octave
            Submitted by: mtmiller
            Submitted on: Wed 13 Nov 2019 01:55:59 PM PST
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Build Failure
                  Status: Confirmed
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: GNU/Linux

    _______________________________________________________

Details:

The NaN package fails to build its mex files with Octave 5.1.0 or later when
the user has LDFLAGS set in the environment. The value of the user's LDFLAGS
doesn't matter. The existence of this variable causes the NaN package makefile
to export its own value of LDFLAGS into all calls to mkoctfile. And the option
'-Wl,--no-undefined' doesn't work when building mex or oct files with Octave
5. Example error:


/tmp/oct-CQVa7c/nan-3.4.3/src/histo_mex.cpp:171: undefined reference to
`mexErrMsgTxt'


My recommendation would be to delete the LDFLAGS variable entirely from
src/Makefile.in.

As a secondary issue, if the user has LDFLAGS in the environment, it would be
better if those options were propagated to the build tools instead of
overwritten.

Attached is a full verbose build log when LDFLAGS was set to
"-L/usr/local/lib" in the shell before starting Octave. The specific value of
LDFLAGS doesn't matter, only that it exists in the environment when make runs.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 13 Nov 2019 01:55:59 PM PST  Name: nan-undefined-errors.log  Size:
13KiB   By: mtmiller

<http://savannah.gnu.org/bugs/download.php?file_id=47863>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57228>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/