[Octave-bug-tracker] [bug #57754] Back out App Nap objc_msgSend fix on Mojave+

[Markus Mützel]

Follow-up Comment #5, bug #57754 (project octave):

I don't have a Mac to test on. But could the following change make it work for
the old and the new prototype of "objc_msgSend"?

diff -r 8f5e625062f3 libgui/src/octave-qobject.cc
--- a/libgui/src/octave-qobject.cc      Thu Feb 13 11:33:27 2020 -0500
+++ b/libgui/src/octave-qobject.cc      Fri Feb 14 16:00:19 2020 +0100
@@ -88,16 +88,18 @@
       == nullptr)
     return;
 
-  process_info = objc_msgSend (reinterpret_cast<id> (process_info_class),
-                               process_info_selector);
+  process_info = reinterpret_cast<id (*)(id, SEL)> (objc_msgSend)
+                   (reinterpret_cast<id> (process_info_class),
+                    process_info_selector);
   if (process_info == nil)
     return;
 
-  reason_string = objc_msgSend (reinterpret_cast<id> (objc_getClass
("NSString")),
-                                sel_getUid ("alloc"));
-  reason_string = objc_msgSend (reason_string,
-                                sel_getUid ("initWithUTF8String:"),
-                                "App Nap causes pause() malfunction");
+  reason_string = reinterpret_cast<id (*)(id, SEL)> (objc_msgSend)
+                    (reinterpret_cast<id> (objc_getClass ("NSString")),
+                     sel_getUid ("alloc"));
+  reason_string = reinterpret_cast<id (*)(id, SEL, const char *)>
(objc_msgSend)
+                    (reason_string, sel_getUid ("initWithUTF8String:"),
+                     "App Nap causes pause() malfunction");
 
   // Start an Activity that suppresses App Nap.  This Activity will run for
   // the entire duration of the Octave process.  This is intentional,


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57754>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/