[Octave-bug-tracker] [bug #57816] macro redefinition warning when installing communications 1.2.2 on 4.4.1

[Andrew Janke]

URL:
  <https://savannah.gnu.org/bugs/?57816>

                 Summary: macro redefinition warning when installing
communications 1.2.2 on 4.4.1
                 Project: GNU Octave
            Submitted by: apjanke
            Submitted on: Fri 14 Feb 2020 10:33:20 PM EST
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Build Failure
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: 4.4.1
         Discussion Lock: Any
        Operating System: Mac OS

    _______________________________________________________

Details:

When installing package communications on Octave 4.4.1 on macOS 10.14, I get
this warning about a redefined macro:


>> pkg install -forge communications
gf.cc:47:9: warning: 'OCTAVE__ERR_SQUARE_MATRIX_REQUIRED' macro redefined
[-Wmacro-redefined]
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) err_square_matrix_required(a,
"")
        ^
gf.cc:43:9: note: previous definition is here
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) gripe_square_matrix_required(a)
        ^
1 warning generated.


Here's the code in gf.cc:


#ifdef HAVE_OCTAVE_GRIPES_H
#include <octave/gripes.h>
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) gripe_square_matrix_required(a)
#endif
#ifdef HAVE_OCTAVE_ERRWARN_H
#include <octave/errwarn.h>
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) err_square_matrix_required(a,
"")
#endif


Sounds like HAVE_OCTAVE_GRIPES_H and HAVE_OCTAVE_ERRWARN_H are not mutually
exclusive? Maybe that should be an "#else ifdef HAV_OCTAVE_ERRWARN_H" in
there?




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57816>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/