[Octave-bug-tracker] [bug #57041] Missing Matlab functions: startsWith and endsWith

[Markus Mützel]

Follow-up Comment #22, bug #57041 (project octave):

I had a closer look at this patch again.
Some more points:
- Also remove the new functions from the list in "__unimplemented__.m".
- Try to avoid duplicating code. E.g. do the input parsing first (setting a
meaningful default value for IgnoreFlag). Then do the actual comparing (with
strncmp or strncmpi, respectively).
- I am not sure why you use the xseealso macro instead of the seealso macro
that is used in other files.
- Also, use the correct case in the seealso macros.
- Add a semicolon to the end of lines with function calls even if they don't
have a return argument ("error" in particular).
- Would it be possible to use strncmpi to check whether the input is
"IgnoreCase" (or the start of it)? Loops tend to be slow in .m files.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57041>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/