[Octave-bug-tracker] [bug #55225] building doc figures in .eps or .pdf format occasionally silently fails

[Markus Mützel]

Follow-up Comment #50, bug #55225 (project octave):

I wasn't affected by the original bug. So I don't know if any testing on my
part is of much help.
But I went ahead anyway and applied your patch on top of hg id 28676df1deaf
locally.
After compiling with it, I ran the dump_plot_demos script from the GUI with
the qt toolbox. I thought that this might be a good test because it creates
and destroys a lot of graphics objects. (Please let me know if it doesn't test
the changes.)
With this test, there don't seem to be any negative side effects on my side.

I'll try with a Windows build next. But - as always - it might take a little
to cross-compile.

As for the question of using "error" or "warning_with_id": I'm probably not
the most qualified person to comment. But I believe to remember that issues
with emitting errors in the GUI thread have been fixed in the past. So I think
it should be ok to raise errors in the GUI thread in general.
Also IIUC, having an invalid "m_object" in the ObjectProxy will most likely
cause problems later on anyway. So erroring out early sounds reasonable to
me.
However, if you are in doubt, maybe it would be safest to push the changes
using "warning_with_id" to stable, merge to default and push another change to
replace "warning_with_id" with "error" on default. (Or push the patch as is to
default, graft to stable and replace "error" with "warning_with_id" on
stable.)

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55225>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/