octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #58216] bar: stacked bar chart improperly hand


From: Nicholas Jankowski
Subject: [Octave-bug-tracker] [bug #58216] bar: stacked bar chart improperly handles negative values
Date: Tue, 17 Nov 2020 16:02:41 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.198 Safari/537.36

Follow-up Comment #10, bug #58216 (project octave):

Ok, I think this patch will correct the negative stacking issue. it separates
the determination of patch y-values when 'stacked' and negative values are
present, then recombines them so the rest of the processing can proceed
unchanged.  this is done within __bar__.m so it fixes both bar and barh.  

There weren't any BISTS to verify that I didn't break anything else, but the
demos still run and the test case below performs as it now should. I added
input error-checking BISTS to both bar and barh and they both pass, and I
added a demo to each that includes the negative values so the behavior is
visibly obvious. Also made a note in the Matlab compatibility section of
NEWS.

diff patch attached along with a zip containing modified bar.m, barh.m and
/private/__bar__.m



(file #50291, file #50292)
    _______________________________________________________

Additional Item Attachment:

File name: fix_negative_stacked_bar.diff  Size:4 KB
   
<https://file.savannah.gnu.org/file/fix_negative_stacked_bar.diff?file_id=50291>

File name: fixstackedbar.zip              Size:8 KB
    <https://file.savannah.gnu.org/file/fixstackedbar.zip?file_id=50292>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58216>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]