[Octave-bug-tracker] [bug #59850] uniquetol missing, so I implemented it

[Markus Mützel]

Update of bug #59850 (project octave):

                  Status:                    None => In Progress            

    _______________________________________________________

Follow-up Comment #3:

Thank you very much. That looks very good to me!

All tests pass for me.

I made only some minor changes to the docstring and style (see attachment).

Some remarks:
* I don't understand the last sentence before the example in the docstring.
(I'm no native speaker. So that might be the reason.) Could you please
re-phrase that sentence? Maybe split it up in two or more sentences.

* It looks like some of the BISTs you added are copies from the examples in
Matlab's documentation. While this is a good check to see if the function is
compatible, I'm not sure if we can take those and distribute them under GPL.
Could you please remove those or replace them with other tests?

I didn't check yet if the docstring compiles. But I think that this function
is almost ready to be added.

Would you like to appear as the author in the changeset? We usually use a real
first (and last) name together with a valid email address as the author of a
changeset.
Which name and email address could I use?
Would you like to appear in the list of contributors (that appears at the
beginning of the manual)?

If you prefer to remain anonymous, I could also push the change with my name.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59850>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/