[Octave-bug-tracker] [bug #31626] lsode: patch to make Jacobian types of dlsode.f accessible

[Markus Mützel]

Update of bug #31626 (project octave):

        Operating System:               GNU/Linux => Any                    

    _______________________________________________________

Follow-up Comment #5:

Sorry, this is taking more than 9 years now.

I applied the last version by Nick of the patch (it still applies) and
compiled with the changes.

I'm not sure if I understand the intention correctly. But I think some
initialization values for the newly added properties are missing from the perl
generated header LSODE-opts.h:

  void init (void)
    {
      x_absolute_tolerance.resize (dim_vector (1, 1));
      x_absolute_tolerance(0) = ::sqrt (std::numeric_limits<double>::epsilon
());
      x_relative_tolerance = ::sqrt (std::numeric_limits<double>::epsilon
());
      x_integration_method = "stiff";
      x_initial_step_size = -1.0;
      x_maximum_order = -1;
      x_maximum_step_size = -1.0;
      x_minimum_step_size = 0.0;
      x_step_limit = 100000;
      x_jacobian_type = "full";
      reset = true;
    }


IIUC, this should include initial values (0) for x_lower_jacobian_subdiagonals
and x_upper_jacobian_subdiagonals.

I think the respective section in the perl script is this:

      if ($INIT_VALUE[$i])
        {
          print "      $OPTVAR[$i] = $INIT_VALUE[$i];\n";
        }


If I interpret that correctly, printing the lines with the default values
might be skipped because they are 0?

I can't read or write perl. So that's over my head.

Attached is a patch with just some minor updates of the formatting of the
docstring.


(file #50920)
    _______________________________________________________

Additional Item Attachment:

File name: bug31626_lsode-jacobian-types_v4.patch Size:5 KB
   
<https://file.savannah.gnu.org/file/bug31626_lsode-jacobian-types_v4.patch?file_id=50920>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?31626>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/