octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #60336] [octave forge] (image) imresize does n


From: Hartmut
Subject: [Octave-bug-tracker] [bug #60336] [octave forge] (image) imresize does not accept complex input values
Date: Sun, 4 Apr 2021 12:56:58 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:87.0) Gecko/20100101 Firefox/87.0

Follow-up Comment #1, bug #60336 (project octave):

I have now even read in the Matlab documentation that the input image for
imresize would need to be real. But this is not true, Matlab behaves
differently, its documentation is just wrong in this point.

I see two ways to make our code more Matlab compatible in this issue, and I am
unsure which one is best:

1. change our private function isimage.m by deleting its check for real-ness.
Pro: imresize (and imremap) could then stay unchanged. And we would still use
our helper function "isimage" as often as we use it now, this makes our code
base more uniform and therefore maybe easier to maintain. Con: In all image
functions that call isimage.m (how many are this?) we would then need to add a
small check for real-ness next to the call to isimage. This makes many
functions a bit more messy (and maybe harder to maintain).

2. change imresize.m (and unfortunatelly also our helper function imremap.m)
such that it does the input checking itself and not uses isimage any more,  it
would mostly check for the same just without the check for real-ness. Con:
This would give us two ugly lines of code at the beginning of each imresize.m
and umremap.m. And we would make use of our isimage helper function two times
less. Pro: we do not need to touch all other image functions.

@Carne, @Avinoam: This seems to be a design decision to me. So please let me
know what you think about this. (I am currently leaning a bit more to version
2...)

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60336>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]