[Octave-bug-tracker] [bug #60334] Embedded Octave crashes on exit in octave::interpreter::~interpreter()

[John W. Eaton]

Follow-up Comment #22, bug #60334 (project octave):

I changed the destructor to be


interpreter::~interepreter (void)
{
  shutdown ();

  delete m_gh_manager;
}


and I only see the warnings if shutdown is called twice.  So it seems that it
should be OK now to call shutdown from the destructor if we prevent the
actions from being performed more than once.  But maybe it would just be
easier to move the shutdown actions to the destructor and make
interpreter::shutdown do nothing (for now; we can deprecate and remove it
later).

The attached patch works for me.  As I said, I thought that doing this caused
trouble for me in the past but I don't know why.  If some situation shows up
that does cause trouble with the destructor arranged this way, then we can try
to fix the real problem.  If you agree, go ahead and push the change or let me
know and I will.


(file #51291)
    _______________________________________________________

Additional Item Attachment:

File name: interp-shutdown-diffs.txt      Size:11 KB
   
<https://file.savannah.gnu.org/file/interp-shutdown-diffs.txt?file_id=51291>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60334>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/